Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation for image source #1266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

qmjose
Copy link

@qmjose qmjose commented Feb 15, 2023

Check for src attribute being defined before setting it. This will help with <source> tags within <picture> tags to avoid the unnecessary src="null" on <source> tag that is required if the source element's parent is an <audio> and <video> element, but not allowed if the source element's parent is a <picture> element.

<picture>
  <source type="..." data-flickity-lazyload-srcset="...">
  ...
<picture>
<picture>
  <source type="..." srcset="..."  src="null">
<picture>

Based on MDN Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant